RussellSpitzer commented on code in PR #7585:
URL: https://github.com/apache/iceberg/pull/7585#discussion_r1192709295
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/SparkShufflingDataRewriter.java:
##########
@@ -67,6 +69,10 @@ protected SparkShufflingDataRewriter(SparkSession spark,
Table table) {
protected abstract org.apache.iceberg.SortOrder sortOrder();
+ protected Schema schema() {
Review Comment:
Can we name this something sort specific? sortSchema? I want to be clear
that this is not necessarily the output schema or the input schema. Javadoc may
help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
