amogh-jahagirdar commented on code in PR #7591:
URL: https://github.com/apache/iceberg/pull/7591#discussion_r1193227616
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetVectorizedReads.java:
##########
@@ -57,6 +58,10 @@ public class TestParquetVectorizedReads extends AvroDataTest
{
static final Function<GenericData.Record, GenericData.Record> IDENTITY =
record -> record;
+ static {
+ System.setProperty("arrow.enable_null_check_for_get", "true");
+ }
Review Comment:
I think I'm overcomplicating this. since Iceberg performs the nullability
check anyways there's not much value for our test path to even validate the
arrow validity buffer (which was the premise of
https://github.com/apache/iceberg/pull/6550/files). I think we can just remove
the assertions related to `checkArrowValidityVector` from these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
