manisin commented on code in PR #7580: URL: https://github.com/apache/iceberg/pull/7580#discussion_r1194247119
########## snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java: ########## @@ -48,8 +51,12 @@ public class SnowflakeCatalog extends BaseMetastoreCatalog // Specifies the name of a Snowflake's partner application to connect through JDBC. // https://docs.snowflake.com/en/user-guide/jdbc-parameters.html#application private static final String JDBC_APPLICATION_PROPERTY = "application"; + // Add a suffix to user agent header for the web requests made by the jdbc driver. + private static final String JDBC_USER_AGENT_SUFFIX_PROPERTY = "user_agent_suffix"; private static final String APP_IDENTIFIER = "iceberg-snowflake-catalog"; - + // Specifies the length of unique id for each catalog initialized session. Should be less than 32 Review Comment: The application id is restricted to 50 characters by the JDBC driver so we need to trim the guid suffix. This does reduce the overall uniqueness but still provides enough uniqueness for our scenario where we want to correlate telemetry in a given time window. I have added comments in the code to clarify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
