szehon-ho commented on PR #7539: URL: https://github.com/apache/iceberg/pull/7539#issuecomment-1548562443
Hi, @dramaticlly as I didnt want to block the change, I had some follow up that I made in #7613 including what we discussed in https://github.com/apache/iceberg/pull/7539#discussion_r1192497611. I think it makes the code between BaseFilesTable and BaseEntriesTable even more similar and with more re-use, if you wanted to take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
