szehon-ho commented on code in PR #7613:
URL: https://github.com/apache/iceberg/pull/7613#discussion_r1194364032
##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -166,21 +161,35 @@ private Schema requiredFileProjection() {
return TypeUtil.join(fileProjection, projectionForReadableMetrics);
}
- private Schema removeReadableMetrics(Types.NestedField
readableMetricsField) {
+ private Schema removeReadableMetrics(
+ Schema projectionSchema, Types.NestedField readableMetricsField) {
Set<Integer> readableMetricsIds =
TypeUtil.getProjectedIds(readableMetricsField.type());
- return TypeUtil.selectNot(projection, readableMetricsIds);
+ return TypeUtil.selectNot(projectionSchema, readableMetricsIds);
}
private StructProjection structProjection(Schema projectedSchema) {
Schema manifestEntrySchema =
ManifestEntry.wrapFileSchema(fileProjection.asStruct());
return StructProjection.create(manifestEntrySchema, projectedSchema);
}
+ /**
+ * @param fileStructProjection projection to apply on the 'data_files'
struct
+ * @return entries of this read task's manifest
+ */
private CloseableIterable<? extends ManifestEntry<? extends
ContentFile<?>>> entries(
- Schema newFileProjection) {
- return ManifestFiles.open(manifest, io,
specsById).project(newFileProjection).entries();
+ Schema fileStructProjection) {
Review Comment:
Make this method a bit more functional (input/output is more clear)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
