ajantha-bhat commented on code in PR #6461:
URL: https://github.com/apache/iceberg/pull/6461#discussion_r1194885610
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -620,20 +626,23 @@ private static class WriterFactory implements
DataWriterFactory, StreamingDataWr
private final Schema writeSchema;
private final StructType dsSchema;
private final boolean partitionedFanoutEnabled;
+ private final boolean isOrderedWrite;
Review Comment:
This `isOrderedWrite` is decided based on `requiredOrdering` field of
`SparkWrite` which is an Array of Spark SortOrder. I don't know how to convert
array of spark sort order to an Iceberg sort order (didn't find an existing
code). I guess only Iceberg sort order has the sort order ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
