aokolnychyi commented on code in PR #7637:
URL: https://github.com/apache/iceberg/pull/7637#discussion_r1197362148
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteMergeIntoTable.scala:
##########
@@ -210,13 +206,11 @@ object RewriteMergeIntoTable extends
RewriteRowLevelIcebergCommand with Predicat
val joinHint = JoinHint(leftHint =
Some(HintInfo(Some(NO_BROADCAST_HASH))), rightHint = None)
val joinPlan = Join(NoStatsUnaryNode(targetTableProj), sourceTableProj,
joinType, Some(cond), joinHint)
- // add an extra matched action to output the original row if none of the
actual actions matched
- // this is needed to keep target rows that should be copied over
- val matchedConditions = matchedActions.map(actionCondition) :+ TrueLiteral
- val matchedOutputs = matchedActions.map(actionOutput(_, metadataAttrs)) :+
readAttrs
+ val matchedConditions = matchedActions.map(actionCondition)
Review Comment:
I can, probably, submit the logic to split updates into deletes and inserts
in a separate PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
