dramaticlly commented on code in PR #7593:
URL: https://github.com/apache/iceberg/pull/7593#discussion_r1198413433
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##########
@@ -41,7 +41,12 @@ case class CreateOrReplaceBranchExec(
override protected def run(): Seq[InternalRow] = {
catalog.loadTable(ident) match {
case iceberg: SparkTable =>
- val snapshotId =
branchOptions.snapshotId.getOrElse(iceberg.table.currentSnapshot().snapshotId())
+ var snapshotId = branchOptions.snapshotId.getOrElse(-1L)
+ if (snapshotId == -1) {
+ val currentSnapshot =
Option(iceberg.table().currentSnapshot()).getOrElse(throw new
IllegalArgumentException(
+ s"Please specify an explicit snapshot as table: $iceberg" + " has
no latest main snapshot"))
+ snapshotId = currentSnapshot.snapshotId()
+ }
Review Comment:
```suggestion
val snapshotId: java.lang.Long = branchOptions.snapshotId
.orElse(Option(iceberg.table.currentSnapshot()).map(_.snapshotId()))
.map(java.lang.Long.valueOf)
.orNull
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
