hililiwei commented on PR #7638: URL: https://github.com/apache/iceberg/pull/7638#issuecomment-1554335242
> This can be fixed by checkpointing the watermark written to snapshot summary or during restore the committer can retrieve the latest committed watermark > I agree that a little bit of logic is needed to determine which partitions have complete data based on the published watermark in snapshot summary. Of course, we can store the watermark, but this does not fundamentally solve the data visibility problem. Writing watermark to Iceberg table is simple, but it increases the complexity of the whole task chain. And in many scenarios, downstream does not have a suitable place to implement this set of processing logic. For example, ad hoc query, OLAP query. >I am not sure this is a fair comparison. Flink filesystem connector is storing files on distributed file system (like S3) directly. there is no table format abstraction. hence success file is the only option. Regarding `SUCCESS`, it is just an built-in partition commit policy. And not only Filesystem, Hive also supports this, see :https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/hive/hive_read_write/#writing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
