dimas-b commented on code in PR #7641:
URL: https://github.com/apache/iceberg/pull/7641#discussion_r1198962340
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -92,6 +92,18 @@ private TableMetadata loadTableMetadata(String
metadataLocation, Reference refer
// Nessie CLI will provide a reference aware GC functionality for the
expired/unreferenced
// files.
newProperties.put(TableProperties.GC_ENABLED, "false");
+
+ boolean metadataCleanupEnabled =
+ newProperties
+
.getOrDefault(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED, "false")
+ .equalsIgnoreCase("true");
+ if (metadataCleanupEnabled) {
+ newProperties.put(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
"false");
+ LOG.warn(
+ "Clean up of table metadata files during commit is disabled as it
can be in use by other references."
+ + " Use nessie-gc tool for reference aware GC");
Review Comment:
How about `Automatic table metadata files cleanup was requested, but
disabled because the Nessie catalog can use historical metadata file. Please
set the " + TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED + " property
to 'false'. Use the 'nessie-gc' tool for history-aware GC".`?
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -92,6 +92,18 @@ private TableMetadata loadTableMetadata(String
metadataLocation, Reference refer
// Nessie CLI will provide a reference aware GC functionality for the
expired/unreferenced
// files.
newProperties.put(TableProperties.GC_ENABLED, "false");
+
+ boolean metadataCleanupEnabled =
+ newProperties
+
.getOrDefault(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED, "false")
+ .equalsIgnoreCase("true");
+ if (metadataCleanupEnabled) {
+ newProperties.put(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
"false");
+ LOG.warn(
+ "Clean up of table metadata files during commit is disabled as it
can be in use by other references."
+ + " Use nessie-gc tool for reference aware GC");
Review Comment:
I guess the WARN is going to be logged on every load, unless the user
permanently resets the `METADATA_DELETE_AFTER_COMMIT_ENABLED` property to
`false`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
