aokolnychyi commented on code in PR #7651:
URL: https://github.com/apache/iceberg/pull/7651#discussion_r1199500163
##########
core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesCommitManager.java:
##########
@@ -55,12 +55,13 @@ public void commit(Set<RewritePositionDeletesGroup>
fileGroups) {
RewriteFiles rewriteFiles =
table.newRewrite().validateFromSnapshot(startingSnapshotId);
for (RewritePositionDeletesGroup group : fileGroups) {
+ long maxSequenceNumber = group.maxRewrittenDataSequenceNumber();
Review Comment:
What about either calling this `maxRewrittenDataSequenceNumber` and adding
an empty line before the for loop below or using
`group.maxRewrittenDataSequenceNumber()` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
