Fokko commented on issue #7658: URL: https://github.com/apache/iceberg/issues/7658#issuecomment-1557025595
I looked into it, and apache commons is a direct dependency of Spark, so I'm not sure if we need to remove it from there. At least other places in Iceberg would be a good idea: ``` ➜ iceberg git:(fd-positional-deletes) ✗ grep --include \*.java -R "org.apache.commons" . ./nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:import org.apache.commons.io.FileUtils; ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * This code is borrowed from `org.apache.commons:commons-lang3`. ./core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: * <p>This code is borrowed from `org.apache.commons:commons-lang3`. ./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalController.java:import org.apache.commons.io.input.BoundedInputStream; ./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:import org.apache.commons.io.FileUtils; ./aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockRule.java:import org.apache.commons.io.FileUtils; ./flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils; ./flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils; ./flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils; ./flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils; ./flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:import org.apache.commons.collections.ListUtils; ./flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java:import org.apache.commons.lang3.StringUtils; ./delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:import org.apache.commons.codec.DecoderException; ./delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java:import org.apache.commons.codec.net.URLCodec; ./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:import org.apache.commons.codec.DecoderException; ./delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:import org.apache.commons.codec.net.URLCodec; ./hive3/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java:import org.apache.commons.lang3.ArrayUtils; ./hive3/src/main/java/org/apache/iceberg/mr/hive/vector/CompatibilityHiveVectorUtils.java:import org.apache.commons.lang3.StringUtils; ./gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSInputStreamTest.java:import org.apache.commons.io.IOUtils; ./gcp/src/test/java/org/apache/iceberg/gcp/gcs/GCSFileIOTest.java:import org.apache.commons.io.IOUtils; ./dell/src/test/java/org/apache/iceberg/dell/mock/ecs/ObjectData.java:import com.emc.object.shadow.org.apache.commons.codec.digest.DigestUtils; ./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java:import org.apache.commons.io.IOUtils; ./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:import org.apache.commons.io.IOUtils; ./aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:import org.apache.commons.lang3.SerializationUtils; ./aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:import org.apache.commons.lang3.SerializationUtils; ./parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java:import org.apache.commons.math3.util.Pair; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
