deniskuzZ commented on code in PR #6527:
URL: https://github.com/apache/iceberg/pull/6527#discussion_r1200575206
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -266,13 +291,23 @@ private CloseableIterable<T> createDeleteIterable(
: Deletes.filterDeleted(records, isDeleted, counter);
}
+ static CloseableIterable<Record> openPosDeletes(FileIO io, DeleteFile file) {
+ InputFile input = io.newInputFile(file.path().toString());
Review Comment:
fixed
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -367,4 +389,86 @@ private static Schema fileProjection(
return new Schema(columns);
}
+
+ public static Map<String, PositionDeleteIndex> createPosIndexMap(
+ Iterable<FileScanTask> fileTasks, FileIO io) {
+ return createPosIndexMap(fileTasks, DEFAULT_SET_FILTER_THRESHOLD, io);
+ }
+
+ public static Map<String, PositionDeleteIndex> createPosIndexMap(
+ Iterable<FileScanTask> fileTasks, long filterThreshold, FileIO io) {
+ List<DeleteFile> posDeletes = distinctPosDeletes(fileTasks);
+ if (posDeletes.isEmpty()) {
+ return ImmutableMap.of();
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
