linyanghao commented on code in PR #7628:
URL: https://github.com/apache/iceberg/pull/7628#discussion_r1201604774
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -472,11 +479,13 @@ public void alterTable(ObjectPath tablePath,
CatalogBaseTable newTable, boolean
CatalogTable table = toCatalogTable(icebergTable);
- // Currently, Flink SQL only support altering table properties.
+ // This alterTable API only supports altering table properties.
Review Comment:
We cannot deprecate this API from iceberg's side, since it's defined in
flink repo. But we can log some warnings inside this method instead. Is that ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
