singhpk234 commented on code in PR #7691:
URL: https://github.com/apache/iceberg/pull/7691#discussion_r1204407229
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestUpdate.java:
##########
@@ -1455,6 +1457,31 @@ public void
testUpdateToWapBranchWithTableBranchIdentifier() {
branch)));
}
+ @Test
+ public void subExpressionEliminationInCodegen() {
Review Comment:
should we now run TestUpdate both with / without Codegen ? as if at the
moment there is a fallback is there is an issue that it silently fallbacks to
interpreted mode which we don't intend, thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
