jzhuge commented on code in PR #7693:
URL: https://github.com/apache/iceberg/pull/7693#discussion_r1204608289


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestIcebergExpressions.java:
##########
@@ -71,4 +72,34 @@ public void testTruncateExpressions() {
         ImmutableList.of(row(100, 10000L, new BigDecimal("10.50"), "10", 
"12")),
         sql("SELECT int_c, long_c, dec_c, str_c, CAST(binary_c AS STRING) FROM 
v"));
   }
+
+  @Test
+  public void testBucketExpressions() {

Review Comment:
   Could you please add another unit test described in issue #7682? Basically 
for a table with binary bucket partition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to