szehon-ho commented on code in PR #7703:
URL: https://github.com/apache/iceberg/pull/7703#discussion_r1207046926
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -1805,23 +1805,32 @@ public void
testRangeCopyOnWriteMergePartitionedSortedTable() {
// -------------------------------------------------------------------------
// delete mode is NOT SET -> CLUSTER BY _spec_id, _partition, _file +
// LOCALLY ORDERED BY _spec_id, _partition, _file,
_pos
+ // delete mode is NOT SET (fanout) -> CLUSTER BY _spec_id, _partition, _file
+ empty ordering
Review Comment:
Oh I see. ok. Well i guess it matters, but the fanoutWriter here will sort
it
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -1805,23 +1805,32 @@ public void
testRangeCopyOnWriteMergePartitionedSortedTable() {
// -------------------------------------------------------------------------
// delete mode is NOT SET -> CLUSTER BY _spec_id, _partition, _file +
// LOCALLY ORDERED BY _spec_id, _partition, _file,
_pos
+ // delete mode is NOT SET (fanout) -> CLUSTER BY _spec_id, _partition, _file
+ empty ordering
Review Comment:
Oh I see. ok. Well i guess it matters in the end, but the fanoutWriter here
will sort it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
