emkornfield commented on code in PR #7504: URL: https://github.com/apache/iceberg/pull/7504#discussion_r1208198169
########## format/view-spec.md: ########## @@ -111,12 +111,13 @@ The SQL representation stores the view definition as a SQL SELECT, with metadata |-------------|---------------------|----------------|-------------| | _required_ | `type` | `string` | Must be `sql` | | _required_ | `sql` | `string` | A SQL SELECT statement | -| _required_ | `dialect` | `string` | The dialect of the `sql` SELECT statement (e.g., "trino" or "spark") | +| _required_ | `dialect` | `string` | The dialect of the `sql` SELECT statement (e.g., "trino" or "spark"). Unless a version is provided only one view definition for each `type` and `dialect` should be present in a view definition. | Review Comment: I'm OK not making this an identifier, if it isn't an identifier, do you think it is still worth tracking this? I think there are still some unanswered questions around how multiple dialects should be handled (e.g. how are they expected to be added/validated by the writer?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
