RussellSpitzer commented on code in PR #7688:
URL: https://github.com/apache/iceberg/pull/7688#discussion_r1210705275
##########
core/src/test/java/org/apache/iceberg/TestSplitPlanning.java:
##########
@@ -218,6 +237,17 @@ public void testSplitPlanningWithOffsets() {
"We should get one task per row group", 32,
Iterables.size(scan.planTasks()));
}
+ @Test
+ public void testAdaptiveSplitPlanningWithOffests() {
+ table.updateProperties().set(TableProperties.ADAPTIVE_SPLIT_PLANNING,
"true").commit();
+
Review Comment:
I think we should have some tests here that show that we are doing the
correct thing even if not enough splits are available. For example if we have 1
file with a single offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
