RussellSpitzer commented on code in PR #7744:
URL: https://github.com/apache/iceberg/pull/7744#discussion_r1211962729
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -89,6 +89,31 @@ static PartitionData fillFromPath(PartitionSpec spec, String
partitionPath, Part
return data;
}
+ static PartitionData fillFromValues(
+ PartitionSpec spec, List<String> partitionValues, PartitionData reuse) {
+ PartitionData data = reuse;
+ if (data == null) {
+ data = newPartitionData(spec);
+ }
+
+ Preconditions.checkArgument(
Review Comment:
Could just do one check here size != size, "Invalid partition data, found %d
fields, expected %d"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
