flyrain commented on code in PR #7326:
URL: https://github.com/apache/iceberg/pull/7326#discussion_r1214730546
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCreateChangelogViewProcedure.java:
##########
@@ -411,6 +413,69 @@ public void testRemoveCarryOversWithoutUpdatedRows() {
sql("select * from %s order by _change_ordinal, id, data", viewName));
}
+ @Test
+ public void testNetChangesWithRemoveCarryOvers() {
+ // partitioned by id
+ createTableWith3Columns();
+
+ // insert rows: (1, 'a', 12) (2, 'b', 11) (2, 'e', 12)
+ sql("INSERT INTO %s VALUES (1, 'a', 12), (2, 'b', 11), (2, 'e', 12)",
tableName);
+ Table table = validationCatalog.loadTable(tableIdent);
+ Snapshot snap1 = table.currentSnapshot();
+
+ // delete rows: (2, 'b', 11) (2, 'e', 12), insert rows: (3, 'c', 13) (2,
'd', 11) (2, 'e', 12)
+ sql("INSERT OVERWRITE %s VALUES (3, 'c', 13), (2, 'd', 11), (2, 'e', 12)",
tableName);
+ table.refresh();
+ Snapshot snap2 = table.currentSnapshot();
+
+ // delete rows: (2, 'd', 11) (2, 'e', 12) (3, 'c', 13), insert rows: (3,
'c', 15) (2, 'e', 12)
+ sql("INSERT OVERWRITE %s VALUES (3, 'c', 15), (2, 'e', 12)", tableName);
+ table.refresh();
+ Snapshot snap3 = table.currentSnapshot();
+
+ // test with all snapshots
+ List<Object[]> returns =
+ sql(
+ "CALL %s.system.create_changelog_view(table => '%s', net_changes
=> true)",
+ catalogName, tableName);
+
+ String viewName = (String) returns.get(0)[0];
+
+ assertEquals(
+ "Rows should match",
+ ImmutableList.of(
+ row(1, "a", 12, INSERT, 0, snap1.snapshotId()),
+ row(3, "c", 15, INSERT, 2, snap3.snapshotId()),
+ row(2, "e", 12, INSERT, 2, snap3.snapshotId())),
+ sql("select * from %s order by _change_ordinal, data", viewName));
+
+ // test with snap2 and snap3
+ sql(
+ "CALL %s.system.create_changelog_view(table => '%s', "
+ + "options => map('start-snapshot-id','%s'), "
+ + "net_changes => true)",
+ catalogName, tableName, snap1.snapshotId());
+
+ assertEquals(
+ "Rows should match",
+ ImmutableList.of(
+ row(2, "b", 11, DELETE, 0, snap2.snapshotId()),
+ row(3, "c", 15, INSERT, 1, snap3.snapshotId())),
+ sql("select * from %s order by _change_ordinal, data", viewName));
+ }
+
+ @Test
+ public void testNetChangesWithComputeUpdates() {
Review Comment:
This is to test the net change with compute update. We don't support it yet.
It should throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
