rdblue commented on code in PR #7750: URL: https://github.com/apache/iceberg/pull/7750#discussion_r1216993219
########## core/src/main/java/org/apache/iceberg/rest/requests/CommitTableRequest.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.requests; + +import java.util.List; +import javax.annotation.Nullable; +import org.apache.iceberg.MetadataUpdate; +import org.apache.iceberg.UpdateRequirement; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.rest.RESTRequest; +import org.immutables.value.Value; + [email protected] +public interface CommitTableRequest extends RESTRequest { Review Comment: I'm wondering if we need a new `CommitTableRequest` or if it would be fine to continue using `UpdateTableRequest`. The breaking change is going to be removing the `List<UpdateTableRequest.UpdateRequirement> requirements()` method, but the `UpdateRequirement` interface is also deprecated and will be removed. Since source compatibility is already going to break, I don't see a problem with moving directly from `List<UpdateTableRequest.UpdateRequirement> requirements()` to `List<UpdateRequirement> requirements()`. The requirements that are returned will implement both interfaces until the older `UpdateTableRequest.UpdateRequirement` is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
