Fokko commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1217016450


##########
python/pyiceberg/catalog/rest.py:
##########
@@ -490,6 +501,36 @@ def rename_table(self, from_identifier: Union[str, 
Identifier], to_identifier: U
 
         return self.load_table(to_identifier)
 
+    def commit_table(
+        self, identifier: Union[str, Identifier], updates: Tuple[TableUpdate, 
...], requirements: Tuple[TableRequirement, ...]
+    ) -> TableResponse:
+        """Updates the table
+
+        Args:
+            identifier (str | Identifier): Namespace identifier
+            updates (Tuple[TableUpdate]): Updates to be applied to the table
+        Raises:
+            NoSuchTableError: If a table with the given identifier does not 
exist
+        """
+        payload = CommitTableRequest(updates=updates).json()

Review Comment:
   I just noticed this as well. Added them here and in all the `commit_table` 
instances.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to