MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1217427024
##########
settings.gradle:
##########
@@ -192,3 +194,186 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+dependencyResolutionManagement {
Review Comment:
I found that toml files [are
supported](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#gradle)
by dependabot but versionCatalog in settings.gradle as I implemented it
currently in this PR [is not yet
supported](https://github.com/dependabot/dependabot-core/issues/3121#issuecomment-1467922666).
I wonder if a hybrid approach is possible, I will investigate. By hybrid I
mean if we leave only dynamic versions in settings.gradle file and move all the
remaining ones to toml file, most would go to toml file as we have just about a
dozen of dynamic dependency versions out of couple hundreds in total. Though
that even if it works would complicate project setup and make it more
difficult to grasp for a project newcomers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
