stevenzwu commented on code in PR #7685:
URL: https://github.com/apache/iceberg/pull/7685#discussion_r1218507775
##########
core/src/main/java/org/apache/iceberg/io/ClusteredWriter.java:
##########
@@ -137,7 +137,7 @@ protected EncryptedOutputFile newOutputFile(
Preconditions.checkArgument(
spec.isUnpartitioned() || partition != null,
"Partition must not be null when creating output file for partitioned
spec");
- return partition == null
+ return spec.isUnpartitioned() || partition == null
Review Comment:
nit: not caused by this PR. but since we are touching the code, should we
use the same style of `if-else`.
I am fine with either if-else or the ternary operator. I know @aokolnychyi
prefers if-else for multi-line statements based on a previous review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
