nastra commented on code in PR #7773: URL: https://github.com/apache/iceberg/pull/7773#discussion_r1219133917
########## CONTRIBUTING.md: ########## @@ -249,7 +249,7 @@ Checks on exceptions should always make sure to assert that a particular excepti ### Awaitility -Avoid using `Thread.sleep()` in tests as it leads to long test durations and flaky behavior if a condition takes slightly longer than expected. +Avoid using `Awaitility` in tests as it leads to long test durations and flaky behavior if a condition takes slightly longer than expected. Review Comment: the original description is correct. we don't want to use `Thread.sleep()` in tests and rather want to use Awaitility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
