Fokko commented on code in PR #7778:
URL: https://github.com/apache/iceberg/pull/7778#discussion_r1220280670
##########
python/pyiceberg/manifest.py:
##########
@@ -266,11 +267,25 @@ def __init__(self, *data: Any, **named_data: Any) -> None:
def fetch_manifest_entry(self, io: FileIO) -> List[ManifestEntry]:
file = io.new_input(self.manifest_path)
- return list(read_manifest_entry(file))
+ return [_inherit_sequence_number(entry, self) for entry in
read_manifest_entry(file)]
Review Comment:
Hmm. There were two paths for fetching the manifest entries, both through
the `files` and `live_files`. I've removed the `files` and `live_files` to do
everything through the ManifestList. Otherwise, we had to change the `files`
and `live_files` signatures by adding the ManifestList for doing the
inheritance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
