jackye1995 commented on code in PR #7444:
URL: https://github.com/apache/iceberg/pull/7444#discussion_r1223235515
##########
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##########
@@ -167,6 +168,90 @@ public class HttpClientProperties implements Serializable {
public static final String APACHE_USE_IDLE_CONNECTION_REAPER_ENABLED =
"http-client.apache.use-idle-connection-reaper-enabled";
+ /**
+ * If this is set under {@link #CLIENT_TYPE}, {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient} will be
used as the HTTP Client
+ */
+ public static final String HTTP_CLIENT_TYPE_NETTYNIO = "nettynio";
+
+ /**
+ * Used to configure connection maximum idle time {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_MAX_IDLE_TIME_MS =
+ "http-client.nettynio.connection-max-idle-time-ms";
+ /**
+ * Used to configure connection acquisition timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_ACQUISITION_TIMEOUT_MS =
+ "http-client.nettynio.connection-acquisition-timeout-ms";
+ /**
+ * Used to configure connection timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_TIMEOUT_MS =
+ "http-client.nettynio.connection-timeout-ms";
+ /**
+ * Used to configure connection time to live {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_TIME_TO_LIVE_MS =
+ "http-client.nettynio.connection-time-to-live-ms";
+ /**
+ * Used to configure maximum concurrency {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_MAX_CONCURRENCY =
"http-client.nettynio.max-concurrency";
+ /**
+ * Used to configure read timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_READ_TIMEOUT =
"http-client.nettynio.read-timeout";
+ /**
+ * Used to configure maximum pending connection acquires {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_MAX_PENDING_CONNECTION_ACQUIRES =
+ "http-client.nettynio.max-pending-connection-acquires";
+ /**
+ * Used to configure write timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_WRITE_TIMEOUT =
"http-client.nettynio.write-timeout";
Review Comment:
nit: can you add time units to this, like `-ms`?
##########
aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java:
##########
@@ -167,6 +168,90 @@ public class HttpClientProperties implements Serializable {
public static final String APACHE_USE_IDLE_CONNECTION_REAPER_ENABLED =
"http-client.apache.use-idle-connection-reaper-enabled";
+ /**
+ * If this is set under {@link #CLIENT_TYPE}, {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient} will be
used as the HTTP Client
+ */
+ public static final String HTTP_CLIENT_TYPE_NETTYNIO = "nettynio";
+
+ /**
+ * Used to configure connection maximum idle time {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_MAX_IDLE_TIME_MS =
+ "http-client.nettynio.connection-max-idle-time-ms";
+ /**
+ * Used to configure connection acquisition timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_ACQUISITION_TIMEOUT_MS =
+ "http-client.nettynio.connection-acquisition-timeout-ms";
+ /**
+ * Used to configure connection timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_TIMEOUT_MS =
+ "http-client.nettynio.connection-timeout-ms";
+ /**
+ * Used to configure connection time to live {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_CONNECTION_TIME_TO_LIVE_MS =
+ "http-client.nettynio.connection-time-to-live-ms";
+ /**
+ * Used to configure maximum concurrency {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_MAX_CONCURRENCY =
"http-client.nettynio.max-concurrency";
+ /**
+ * Used to configure read timeout {@link
+ * software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient.Builder}.
This flag only works
+ * when {@link #CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_NETTYNIO}.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.Builder.html
+ */
+ public static final String NETTYNIO_READ_TIMEOUT =
"http-client.nettynio.read-timeout";
Review Comment:
nit: can you add time units to this, like `-ms`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
