ChristinaTech commented on code in PR #7718:
URL: https://github.com/apache/iceberg/pull/7718#discussion_r1224689798
##########
core/src/test/java/org/apache/iceberg/util/TestSnapshotUtil.java:
##########
@@ -60,12 +62,23 @@ public class TestSnapshotUtil {
.withRecordCount(1)
.build();
- private long snapshotAId;
+ private long snapshotBaseTimestamp;
+ private long snapshotBaseId;
+ private long snapshotBranchId;
+ private long snapshotMain1Id;
+ private long snapshotMain2Id;
+ private long snapshotFork0Id;
+ private long snapshotFork1Id;
+ private long snapshotFork2Id;
+
+ private Snapshot putSnapshot(String branch) {
Review Comment:
Will change it to this.
##########
core/src/test/java/org/apache/iceberg/util/TestSnapshotUtil.java:
##########
@@ -60,12 +62,23 @@ public class TestSnapshotUtil {
.withRecordCount(1)
.build();
- private long snapshotAId;
+ private long snapshotBaseTimestamp;
+ private long snapshotBaseId;
+ private long snapshotBranchId;
+ private long snapshotMain1Id;
+ private long snapshotMain2Id;
+ private long snapshotFork0Id;
+ private long snapshotFork1Id;
+ private long snapshotFork2Id;
+
+ private Snapshot putSnapshot(String branch) {
+ table.newFastAppend().appendFile(FILE_A).toBranch(branch).commit();
+ return table.snapshot(branch);
+ }
- private long snapshotATimestamp;
- private long snapshotBId;
- private long snapshotCId;
- private long snapshotDId;
+ private Snapshot putSnapshot() {
Review Comment:
Will change it to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
