rdblue commented on code in PR #6450:
URL: https://github.com/apache/iceberg/pull/6450#discussion_r1224797722
##########
core/src/main/java/org/apache/iceberg/avro/GenericAvroReader.java:
##########
@@ -30,13 +30,17 @@
import org.apache.iceberg.common.DynClasses;
import org.apache.iceberg.data.avro.DecoderResolver;
-class GenericAvroReader<T> implements DatumReader<T>, SupportsRowPosition {
+public class GenericAvroReader<T> implements DatumReader<T>,
SupportsRowPosition {
Review Comment:
Note about this to myself for later...
This needs to use `GenericAvroReader` for a couple reasons. First,
`GenericAvroReader` is the only one that supports creating records with a
specific class. We could extend support so that `DataReader` can create
`StructLike` instances, but that hits the second reason: using Iceberg generics
will use different representations for some types, like using `LocalDate`
instead of `int` for `date` type. The representation differences don't affect
the `KeyMetadata` class right now, but it's still more correct to use the
internal representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
