MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1231853372
##########
build.gradle:
##########
@@ -212,15 +203,15 @@ subprojects {
targetCompatibility = '1.8'
dependencies {
- implementation 'org.slf4j:slf4j-api'
+ implementation libs.slf4j.api
- testImplementation 'org.junit.vintage:junit-vintage-engine'
- testImplementation 'org.junit.jupiter:junit-jupiter-engine'
- testImplementation 'org.junit.jupiter:junit-jupiter'
- testImplementation 'org.slf4j:slf4j-simple'
- testImplementation 'org.mockito:mockito-core'
- testImplementation 'org.mockito:mockito-inline'
- testImplementation 'org.assertj:assertj-core'
+ testImplementation libs.junit.vintage.engine
Review Comment:
I had to revert it back as compileTestJava started to fail for iceberg-dell
and iceberg-aliyun, If that's something that is not a part of a transition to
VersionCatalog, can we do it separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
