rdblue commented on code in PR #7569:
URL: https://github.com/apache/iceberg/pull/7569#discussion_r1234221460
##########
core/src/main/java/org/apache/iceberg/rest/requests/UpdateTableRequest.java:
##########
@@ -35,21 +35,22 @@
public class UpdateTableRequest implements RESTRequest {
private TableIdentifier identifier;
- private List<UpdateRequirement> requirements;
+ private List<org.apache.iceberg.UpdateRequirement> requirements;
private List<MetadataUpdate> updates;
public UpdateTableRequest() {
// needed for Jackson deserialization
}
- public UpdateTableRequest(List<UpdateRequirement> requirements,
List<MetadataUpdate> updates) {
+ public UpdateTableRequest(
+ List<org.apache.iceberg.UpdateRequirement> requirements,
List<MetadataUpdate> updates) {
this.requirements = requirements;
this.updates = updates;
}
- UpdateTableRequest(
+ public UpdateTableRequest(
Review Comment:
Maybe we should have a `create` method like `TableCommit`? Or one that
accepts a `TableCommit` and returns the correct request? That would be simpler
than a builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
