rdblue commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1234561260
##########
python/pyiceberg/catalog/rest.py:
##########
@@ -489,6 +493,39 @@ def rename_table(self, from_identifier: Union[str,
Identifier], to_identifier: U
return self.load_table(to_identifier)
+ def _commit(self, *table_requests: CommitTableRequest) ->
CommitTableResponse:
Review Comment:
Do we want to combine these? Why not have separate `commit_table` and
`commit_transaction` methods? Then we don't need the check that only one
request is supported. I also like that you could previously pass requirements
and updates to a public method. Are you trying to restrict access to those in
the "public" API for some reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
