liuxiaocs7 commented on code in PR #7868:
URL: https://github.com/apache/iceberg/pull/7868#discussion_r1236434702
##########
core/src/test/java/org/apache/iceberg/TestManifestReaderStats.java:
##########
@@ -275,9 +275,6 @@ private void assertStatsDropped(DataFile dataFile) {
private void assertNullRecordCount(DataFile dataFile) {
// record count is a primitive type, accessing null record count will
throw NPE
- AssertHelpers.assertThrows(
- "Should throw NPE when accessing non-populated record count field",
- NullPointerException.class,
- dataFile::recordCount);
+
Assertions.assertThatThrownBy(dataFile::recordCount).isInstanceOf(NullPointerException.class);
Review Comment:
yep, i use `.hasMessage(null)` in
https://github.com/apache/iceberg/pull/7868/commits/ed4c890a4f6225d94f898a2260ba3712706eb821,
it works in my local env, but fails in this action
https://github.com/apache/iceberg/actions/runs/5322419639/jobs/9638844493
any suggestions? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
