wypoon commented on PR #7744: URL: https://github.com/apache/iceberg/pull/7744#issuecomment-1601410308
> This PR is a bit challenging to review because it combines several cosmetic refactors with the actual code making the change. It would probably be much easier to read if we could separate out all the refactors that do not contribute to the core task of "handling partitions with a special character." Further changes to improve readability and so forth should go in a separate PR. I hear you. I shall remove the cosmetic refactors (except for renaming variables in `listPartitions`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
