nastra commented on code in PR #7872:
URL: https://github.com/apache/iceberg/pull/7872#discussion_r1238045144
##########
dell/src/test/java/org/apache/iceberg/dell/mock/ecs/EcsS3MockRule.java:
##########
@@ -71,7 +72,7 @@ public static EcsS3MockRule manualCreateBucket() {
/** Load rule from thread local and check bucket */
public static EcsS3MockRule rule(String id) {
EcsS3MockRule rule = TEST_RULE_FOR_MOCK_CLIENT.get();
- Assert.assertTrue("Test Rule must match id", rule != null &&
rule.bucket().equals(id));
+ assertThat(rule != null && rule.bucket().equals(id)).as("Test Rule must
match id").isTrue();
Review Comment:
```suggestion
assertThat(rule).isNotNull().extracting(EcsS3MockRule::bucket).isEqualTo(id);
```
##########
arrow/src/test/java/org/apache/iceberg/arrow/ArrowSchemaUtilTest.java:
##########
@@ -97,86 +98,86 @@ public void convertComplex() {
MapType.ofOptional(
4, 5, StringType.get(), ListType.ofOptional(6,
TimestampType.withoutZone()))));
org.apache.arrow.vector.types.pojo.Schema arrow =
ArrowSchemaUtil.convert(iceberg);
- Assert.assertEquals(iceberg.columns().size(), arrow.getFields().size());
+ assertThat(arrow.getFields().size()).isEqualTo(iceberg.columns().size());
}
private void validate(Schema iceberg,
org.apache.arrow.vector.types.pojo.Schema arrow) {
- Assert.assertEquals(iceberg.columns().size(), arrow.getFields().size());
+ assertThat(arrow.getFields().size()).isEqualTo(iceberg.columns().size());
Review Comment:
```suggestion
assertThat(arrow.getFields()).hasSameSizeAs(iceberg.columns());
```
##########
arrow/src/test/java/org/apache/iceberg/arrow/ArrowSchemaUtilTest.java:
##########
@@ -97,86 +98,86 @@ public void convertComplex() {
MapType.ofOptional(
4, 5, StringType.get(), ListType.ofOptional(6,
TimestampType.withoutZone()))));
org.apache.arrow.vector.types.pojo.Schema arrow =
ArrowSchemaUtil.convert(iceberg);
- Assert.assertEquals(iceberg.columns().size(), arrow.getFields().size());
+ assertThat(arrow.getFields().size()).isEqualTo(iceberg.columns().size());
Review Comment:
```suggestion
assertThat(arrow.getFields()).hasSameSizeAs(iceberg.columns());
```
##########
arrow/src/test/java/org/apache/iceberg/arrow/ArrowSchemaUtilTest.java:
##########
@@ -97,86 +98,86 @@ public void convertComplex() {
MapType.ofOptional(
4, 5, StringType.get(), ListType.ofOptional(6,
TimestampType.withoutZone()))));
org.apache.arrow.vector.types.pojo.Schema arrow =
ArrowSchemaUtil.convert(iceberg);
- Assert.assertEquals(iceberg.columns().size(), arrow.getFields().size());
+ assertThat(arrow.getFields().size()).isEqualTo(iceberg.columns().size());
}
private void validate(Schema iceberg,
org.apache.arrow.vector.types.pojo.Schema arrow) {
- Assert.assertEquals(iceberg.columns().size(), arrow.getFields().size());
+ assertThat(arrow.getFields().size()).isEqualTo(iceberg.columns().size());
for (Types.NestedField nf : iceberg.columns()) {
Field field = arrow.findField(nf.name());
- Assert.assertNotNull("Missing filed: " + nf, field);
+ assertThat(field).as("Missing filed: " + nf).isNotNull();
Review Comment:
```suggestion
assertThat(field).as("Missing field: " + nf).isNotNull();
```
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##########
@@ -349,20 +348,20 @@ private void readAndCheckHasNextIsIdempotent(
// Call hasNext() a few extra times.
// This should not affect the total number of rows read.
for (int i = 0; i < numExtraCallsToHasNext; i++) {
- assertTrue(iterator.hasNext());
+ assertThat(iterator.hasNext()).isTrue();
Review Comment:
```suggestion
assertThat(iterator).hasNext();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
