chasebradford commented on code in PR #7833:
URL: https://github.com/apache/iceberg/pull/7833#discussion_r1239486791
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -275,17 +273,12 @@ private CloseableIterable<Record> openDeletes(DeleteFile
deleteFile, Schema dele
InputFile input = getInputFile(deleteFile.path().toString());
switch (deleteFile.format()) {
case AVRO:
- return Avro.read(input)
- .project(deleteSchema)
- .reuseContainers()
- .createReaderFunc(DataReader::create)
- .build();
+ return
Avro.read(input).project(deleteSchema).createReaderFunc(DataReader::create).build();
Review Comment:
PR checks fail after wrapping :(
```
> The following files had format violations:
See
https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
src/main/java/org/apache/iceberg/data/DeleteFilter.java
62 actionable tasks: 62 executed
@@ -273,10 +273,7 @@
····InputFile·input·=·getInputFile(deleteFile.path().toString());
····switch·(deleteFile.format())·{
······case·AVRO:
-········return·Avro.read(input)
-············.project(deleteSchema)
-············.createReaderFunc(DataReader::create)
-············.build();
+········return·Avro.read(input).project(deleteSchema).createReaderFunc(DataReader::create).build();
······case·PARQUET:
········Parquet.ReadBuilder·builder·=
Run './gradlew :iceberg-data:spotlessApply' to fix these violations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
