rdblue commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1240434980
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java:
##########
@@ -600,10 +602,10 @@ private List<Record> expected(int... ordinals) {
return expected;
}
- private void pushFilters(ScanBuilder scan, Filter... filters) {
- Assertions.assertThat(scan).isInstanceOf(SupportsPushDownFilters.class);
- SupportsPushDownFilters filterable = (SupportsPushDownFilters) scan;
- filterable.pushFilters(filters);
+ private void pushFilters(ScanBuilder scan, Predicate... predicates) {
Review Comment:
Why add `.toV2` everywhere instead of just calling it here? Seems like this
would be an easier place to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
