jackye1995 commented on code in PR #7880:
URL: https://github.com/apache/iceberg/pull/7880#discussion_r1246905024
##########
api/src/main/java/org/apache/iceberg/view/ViewBuilder.java:
##########
@@ -111,6 +111,16 @@ public interface ViewBuilder {
*/
ViewBuilder withProperty(String key, String value);
+ /**
+ * Add a view representation
+ *
+ * @param representation The view representation to add
+ * @return this for method chaining
+ */
+ default ViewBuilder withRepresentation(ViewRepresentation representation) {
Review Comment:
I am starting to wonder, do we still need this `ViewBuilder` for all these
parts? We have switched to immutable for everything else, would it be better to
also do that for `View`? And we just keep the `create()`, `replace()`,
`createOrReplace()` to complete the creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
