ConeyLiu commented on code in PR #7933:
URL: https://github.com/apache/iceberg/pull/7933#discussion_r1248834540
##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -64,17 +68,30 @@ abstract class BaseCommitService<T> implements Closeable {
* @param rewritesPerCommit number of file groups to include in a commit
*/
BaseCommitService(Table table, int rewritesPerCommit) {
+ this(table, rewritesPerCommit, TIMEOUT_IN_MS_DEFAULT);
+ }
+
+ /**
+ * Constructs a {@link BaseCommitService}
+ *
+ * @param table table to perform commit on
+ * @param rewritesPerCommit number of file groups to include in a commit
+ * @param timeoutInMS The timeout to wait for commits to complete after all
rewrite jobs have been
+ * completed
+ */
+ BaseCommitService(Table table, int rewritesPerCommit, long timeoutInMS) {
this.table = table;
LOG.info(
"Creating commit service for table {} with {} groups per commit",
table, rewritesPerCommit);
this.rewritesPerCommit = rewritesPerCommit;
+ this.timeoutInMS = timeoutInMS;
committerService =
Executors.newSingleThreadExecutor(
new
ThreadFactoryBuilder().setNameFormat("Committer-Service").build());
completedRewrites = Queues.newConcurrentLinkedQueue();
- committedRewrites = Lists.newArrayList();
+ committedRewrites = Queues.newConcurrentLinkedQueue();
Review Comment:
`committedRewrites` could be updated concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
