nastra commented on code in PR #7957:
URL: https://github.com/apache/iceberg/pull/7957#discussion_r1250396696
##########
aws/src/test/java/org/apache/iceberg/aws/glue/TestGlueCatalog.java:
##########
@@ -602,17 +601,18 @@ public void testTablePropsDefinedAtCatalogLevel() {
null,
catalogProps);
Map<String, String> properties = glueCatalog.properties();
- Assert.assertFalse(properties.isEmpty());
- Assert.assertTrue(properties.containsKey("table-default.key1"));
- Assert.assertEquals("catalog-default-key1",
properties.get("table-default.key1"));
- Assert.assertTrue(properties.containsKey("table-default.key2"));
- Assert.assertEquals("catalog-default-key2",
properties.get("table-default.key2"));
- Assert.assertTrue(properties.containsKey("table-default.key3"));
- Assert.assertEquals("catalog-default-key3",
properties.get("table-default.key3"));
- Assert.assertTrue(properties.containsKey("table-override.key3"));
- Assert.assertEquals("catalog-override-key3",
properties.get("table-override.key3"));
- Assert.assertTrue(properties.containsKey("table-override.key4"));
- Assert.assertEquals("catalog-override-key4",
properties.get("table-override.key4"));
+ Assertions.assertThat(properties)
+ .isNotEmpty()
+ .containsKey("table-default.key1")
Review Comment:
we can omit all the `containsKey` calls for which we also check
`containsEntry`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
