skytin1004 commented on code in PR #7954:
URL: https://github.com/apache/iceberg/pull/7954#discussion_r1250475024
##########
orc/src/test/java/org/apache/iceberg/orc/TestOrcDeleteWriters.java:
##########
@@ -163,13 +162,14 @@ public void testPositionDeleteWriter() throws IOException
{
deletedRecords = Lists.newArrayList(reader);
}
- Assert.assertEquals(
- "Deleted records should match expected", expectedDeleteRecords,
deletedRecords);
+ Assertions.assertThat(deletedRecords)
+ .as("Deleted records should match expected")
+ .isEqualTo(expectedDeleteRecords);
}
@Test
public void testPositionDeleteWriterWithEmptyRow() throws IOException {
- File deleteFile = temp.newFile();
+ File deleteFile = temp;
Review Comment:
I've removed the `deleteFile`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
