snazy commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1250480704
##########
build.gradle:
##########
@@ -212,15 +203,15 @@ subprojects {
targetCompatibility = '1.8'
dependencies {
- implementation 'org.slf4j:slf4j-api'
+ implementation libs.slf4j.api
- testImplementation 'org.junit.vintage:junit-vintage-engine'
- testImplementation 'org.junit.jupiter:junit-jupiter-engine'
- testImplementation 'org.junit.jupiter:junit-jupiter'
- testImplementation 'org.slf4j:slf4j-simple'
- testImplementation 'org.mockito:mockito-core'
- testImplementation 'org.mockito:mockito-inline'
- testImplementation 'org.assertj:assertj-core'
+ testImplementation libs.junit.vintage.engine
Review Comment:
Just noting: even test code should not have a compile-time (*implementation
*compileOnly etc) dependency to an engine. That's a project issue though.
##########
settings.gradle:
##########
@@ -192,3 +194,27 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
}
}
+dependencyResolutionManagement {
+ versionCatalogs {
+ libs {
+ from(files("./libs.versions.toml"))
+
+ library("delta-standalone",
"io.delta:delta-standalone_${scalaVersion}:0.6.0")
+ library("flink115-table-planner",
"org.apache.flink:flink-table-planner_${scalaVersion}:1.15.0")
+ library("flink116-table-planner",
"org.apache.flink:flink-table-planner_${scalaVersion}:1.16.2")
+ library("flink117-table-planner",
"org.apache.flink:flink-table-planner_${scalaVersion}:1.17.1")
+ library("jackson211-module-scala",
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:2.11.4")
+ library("jackson212-module-scala",
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:2.12.3")
+ library("jackson213-module-scala",
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:2.13.4")
+ library("scala-collection-compat",
"org.scala-lang.modules:scala-collection-compat_${scalaVersion}:2.6.0")
Review Comment:
Maybe add a `.get()` ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
