Fokko commented on PR #7968:
URL: https://github.com/apache/iceberg/pull/7968#issuecomment-1618258925
I like the idea of spotting dependencies that we don't use. But it seems
like we don't run these checks?
```
➜ iceberg git:(51eaf6806) ./gradlew checkUnusedDependencies
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :iceberg-flink:checkUnusedDependenciesMain FAILED
> Task :iceberg-spark:checkUnusedDependenciesMain FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':iceberg-flink:checkUnusedDependenciesMain'.
> Found 1 dependencies unused during compilation, please delete them from
'flink/build.gradle' or choose one of the suggested fixes:
org.slf4j:slf4j-api
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':iceberg-spark:checkUnusedDependenciesMain'.
> Found 1 dependencies unused during compilation, please delete them from
'spark/build.gradle' or choose one of the suggested fixes:
org.slf4j:slf4j-api
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================
* Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
See
https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 8s
11 actionable tasks: 11 executed
➜ iceberg git:(51eaf6806) ./gradlew checkImplicitDependencies
> Task :iceberg-bundled-guava:shadowJar
Encountered duplicate path "META-INF/MANIFEST.MF" during copy operation
configured with DuplicatesStrategy.WARN
Encountered duplicate path "org/apache/iceberg/GuavaClasses.class" during
copy operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "guava-31.1-jre.jar" during copy operation
configured with DuplicatesStrategy.WARN
Encountered duplicate path "failureaccess-1.0.1.jar" during copy operation
configured with DuplicatesStrategy.WARN
Encountered duplicate path
"listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar" during copy
operation configured with DuplicatesStrategy.WARN
Encountered duplicate path "LICENSE" during copy operation configured with
DuplicatesStrategy.WARN
Encountered duplicate path "NOTICE" during copy operation configured with
DuplicatesStrategy.WARN
> Task :iceberg-common:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
> Task :iceberg-api:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :iceberg-api:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :iceberg-api:testJar
Encountered duplicate path "iceberg-build.properties" during copy operation
configured with DuplicatesStrategy.WARN
> Task :iceberg-api:checkImplicitDependenciesTest FAILED
> Task :iceberg-core:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':iceberg-api:checkImplicitDependenciesTest'.
> Found 2 implicit dependencies - consider adding the following explicit
dependencies to 'api/build.gradle', or avoid using classes from these jars:
dependencies {
testImplementation 'org.junit.jupiter:junit-jupiter-api'
testImplementation 'org.objenesis:objenesis'
}
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
See
https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 15s
28 actionable tasks: 19 executed, 9 up-to-date
```
I'm open to removing it when it introduces issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
