rdblue commented on code in PR #6599:
URL: https://github.com/apache/iceberg/pull/6599#discussion_r1252392805
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -82,6 +83,24 @@ public static String toSanitizedString(Expression expr) {
return ExpressionVisitors.visit(expr, new StringSanitizer());
}
+ /**
+ * Extracts an expression that references only the given column IDs from the
given expression.
+ *
+ * <p>The result is inclusive. If a row would match the original filter, it
must match the result
+ * filter.
+ *
+ * @param expression a filter Expression
+ * @param schema a Schema
+ * @param caseSensitive whether binding is case sensitive
+ * @param ids field IDs used to match predicates to extract from the
expression
+ * @return an Expression that selects at least the same rows as the original
using only the IDs
+ */
+ public static Expression extractByIdInclusive(
Review Comment:
Looks like the tests were missing. I'll add those when I clean this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
