nastra commented on code in PR #7988:
URL: https://github.com/apache/iceberg/pull/7988#discussion_r1254451323
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -662,15 +681,4 @@ private List<String> filterByExtension(String tablePath,
String extension) {
.filter(f -> f.endsWith(extension))
.collect(Collectors.toList());
}
-
- private static String addRecordsToFile(Table table, String filename) throws
IOException {
Review Comment:
why the change to move this from here to the top?
##########
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java:
##########
@@ -21,7 +21,6 @@
import java.io.IOException;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang3.ArrayUtils;
Review Comment:
should compilation not fail here?
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java:
##########
@@ -41,6 +40,74 @@
class ParquetAvro {
+ static final GenericData DEFAULT_MODEL =
Review Comment:
it's hard to follow which changes were exactly done in this file due to the
large diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
