zinking commented on code in PR #8023:
URL: https://github.com/apache/iceberg/pull/8023#discussion_r1260451132
##########
spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/AssignmentAlignmentSupport.scala:
##########
@@ -46,31 +45,31 @@ trait AssignmentAlignmentSupport extends CastSupport {
private case class ColumnUpdate(ref: Seq[String], expr: Expression)
/**
- * Aligns assignments to match table columns.
- * <p>
- * This method processes and reorders given assignments so that each target
column gets
- * an expression it should be set to. If a column does not have a matching
assignment,
- * it will be set to its current value. For example, if one passes a table
with columns c1, c2
- * and an assignment c2 = 1, this method will return c1 = c1, c2 = 1.
- * <p>
- * This method also handles updates to nested columns. If there is an
assignment to a particular
- * nested field, this method will construct a new struct with one field
updated
+ * Aligns assignments to match table columns. <p> This method processes and
reorders given
+ * assignments so that each target column gets an expression it should be
set to. If a column does
+ * not have a matching assignment, it will be set to its current value. For
example, if one passes
+ * a table with columns c1, c2 and an assignment c2 = 1, this method will
return c1 = c1, c2 = 1.
+ * <p> This method also handles updates to nested columns. If there is an
assignment to a
+ * particular nested field, this method will construct a new struct with one
field updated
* preserving other fields that have not been modified. For example, if one
passes a table with
- * columns c1, c2 where c2 is a struct with fields n1 and n2 and an
assignment c2.n2 = 1,
- * this method will return c1 = c1, c2 = struct(c2.n1, 1).
+ * columns c1, c2 where c2 is a struct with fields n1 and n2 and an
assignment c2.n2 = 1, this
+ * method will return c1 = c1, c2 = struct(c2.n1, 1).
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
