[ 
https://issues.apache.org/jira/browse/IGNITE-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707676#comment-14707676
 ] 

ASF GitHub Bot commented on IGNITE-884:
---------------------------------------

GitHub user vkulichenko opened a pull request:

    https://github.com/apache/ignite/pull/27

    IGNITE-884 (Cache store usability issues)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkulichenko/incubator-ignite ignite-884

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit c3459a2dfd31de86b10aa8ab5abcc0ce5588e9d5
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-13T05:08:21Z

    IGNITE-884 - Spring autowiring

commit db8eb5582bec4d5bdc853f5d49c121321df992f8
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-15T21:54:06Z

    Merge branch 'ignite-sprint-6' of 
https://git-wip-us.apache.org/repos/asf/incubator-ignite into ignite-884

commit 8c0cc4f14294e43ffe1be172f56e5d06fe587c31
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-16T02:42:18Z

    IGNITE-884 - Spring autowiring

commit d41af24d2ff94a66325b40e6ea268871264caf61
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-16T03:04:12Z

    IGNITE-884 - Spring autowiring

commit 3fa3a5410c097e1611a80ec610ddb98a6549b78c
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-16T23:19:26Z

    Merge branches 'ignite-884' and 'ignite-sprint-6' of 
https://git-wip-us.apache.org/repos/asf/incubator-ignite into ignite-884
    
    Conflicts:
        
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java

commit edc42c42760166a114b88699ceadd21cef13a3ad
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-16T23:39:59Z

    IGNITE-884 - Spring autowiring

commit e0110110d7d68860cede0e5161c1a9259e825628
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-18T01:43:20Z

    Merge branches 'ignite-884' and 'ignite-sprint-6' of 
https://git-wip-us.apache.org/repos/asf/incubator-ignite into ignite-884

commit aaa7818e03b182744960ec3babfb215d306d5878
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-18T01:45:17Z

    IGNITE-884 - Spring autowiring

commit 5a3c88ada0bcf2f2835fc6a1bcff7d8a27851437
Author: Valentin Kulichenko <[email protected]>
Date:   2015-06-18T02:10:49Z

    IGNITE-884 - Spring autowiring

commit 56c20e99c119cef99c2fcb85376c06439f53a480
Author: Valentin Kulichenko <[email protected]>
Date:   2015-07-17T19:06:47Z

    IGNITE-884 - Merged from master

commit 4243b38b774da2086b334a36e2c4f07dde2a9d73
Author: Valentin Kulichenko <[email protected]>
Date:   2015-07-17T19:27:57Z

    IGNITE-884 - Fixed compilation

commit 794f2a00db3783081b7f4069cf82b827f801761f
Author: Valentin Kulichenko <[email protected]>
Date:   2015-07-20T20:40:28Z

    Merge branches 'ignite-884' and 'master' of 
https://git-wip-us.apache.org/repos/asf/incubator-ignite into ignite-884

commit fa740591208509f8cf20be195eda2a81db04ee31
Author: Valentin Kulichenko <[email protected]>
Date:   2015-08-22T00:10:56Z

    Merge branches 'ignite-884' and 'master' of 
github.com:vkulichenko/incubator-ignite into ignite-884

commit 3b20010edbbb383277b062249e482369c949d3fe
Author: Valentin Kulichenko <[email protected]>
Date:   2015-08-22T00:12:59Z

    Merge branch 'master' of github.com:vkulichenko/incubator-ignite into 
ignite-884

----


> Cache store usability issues
> ----------------------------
>
>                 Key: IGNITE-884
>                 URL: https://issues.apache.org/jira/browse/IGNITE-884
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: sprint-4
>            Reporter: Valentin Kulichenko
>            Assignee: Valentin Kulichenko
>            Priority: Critical
>             Fix For: ignite-1.4
>
>
> * Need to validate read/write-through configuration. Currently, when cache 
> store is configured, but {{readThrough}} and {{writeThrough}} flags on 
> {{CacheConfiguration}} are switched off, the store will never be called, 
> which is confusing. This case should be validated and proper warning should 
> be printed out on startup (we can't throw an exception here because in some 
> cases store implements only {{loadCache}} method and is not used for 
> read/write-through).
> * Since cache store is instantiated by Ignite via factory, but not by Spring, 
> user can't use Spring auto-wiring which is very common in Spring apps. Need 
> to create utility method which will instantiate an instance with a factory 
> and properly initialize it. All factory calls (store, expiry policy, ...) 
> should be replaced with this utility method.
> To manually enable autowiring this code can be used:
> {code}
> appCtx.getAutowireCapableBeanFactory().autowireBean(obj);
> {code}
> ({{appCtx}} is Spring's {{ApplicationContext}})



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to