[ 
https://issues.apache.org/jira/browse/IGNITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728686#comment-14728686
 ] 

Denis Magda commented on IGNITE-1353:
-------------------------------------

Alex, thanks for the review!

Eventually did the following:
- removed predefined classes set from portable context;
- removed the map from portable writer that kept info whether the optimized 
marshaller have to be used instead of the portable one during object 
marshalling/unmarshalling;
- removed confusing {{PortableContext.typeId(Class)}} method;
- class descriptor is used now for achieving the same functionality.

Checking the changes with TC. 

> PortableContext.typeId() incorrectly resolves type ID for predefined system 
> types.
> ----------------------------------------------------------------------------------
>
>                 Key: IGNITE-1353
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1353
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: ignite-1.4
>            Reporter: Vladimir Ozerov
>            Assignee: Denis Magda
>            Priority: Critical
>             Fix For: ignite-1.4
>
>
> See PortableContext.typeId() method.
> First it checks whether type is "system", and only then try picking 
> predefiend ID. As a result, predefined types like IgniteBiTuple are written 
> with wrong IDs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to