[ 
https://issues.apache.org/jira/browse/IGNITE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734798#comment-14734798
 ] 

Semen Boikov commented on IGNITE-264:
-------------------------------------

Reviewed, looks good, have minor comments:
- in GridDhtTransactionalCacheAdapter.lockAllAsync force key request was 
removed, so GridEmbeddedFuture is not needed. Also noticed (not related to this 
change) that there is the same unneeded GridEmbeddedFuture in 
IgniteTxHandler.prepareColocatedTx
- new added method is not used: 
GridDhtTxPrepareFuture.originatingNodeHasNearCache
- in PortableContext.registerUserClassDescriptor parameter 'registerMetadata' 
is not used, is it ok?

> Queue failover tests fail in transactional cache
> ------------------------------------------------
>
>                 Key: IGNITE-264
>                 URL: https://issues.apache.org/jira/browse/IGNITE-264
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: sprint-1
>            Reporter: Valentin Kulichenko
>            Assignee: Alexey Goncharuk
>             Fix For: ignite-1.4
>
>
> See {{GridCachePartitionedQueueFailoverDataConsistencySelfTest}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to